Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include JUnit 5.9 in build #652

Closed
beatngu13 opened this issue Jul 14, 2022 · 3 comments
Closed

Include JUnit 5.9 in build #652

beatngu13 opened this issue Jul 14, 2022 · 3 comments

Comments

@beatngu13
Copy link
Member

JUnit 5.9.0-RC1 has been released:

https://junit.org/junit5/docs/snapshot/release-notes/#release-notes-5.9.0-RC1

So the final release is probably just around the corner.

Including 5.9.0-RC1 into our build:

12edd78

Currently causes the following error:

/home/runner/work/junit-pioneer/junit-pioneer/src/test/java/org/junitpioneer/internal/TestExtensionContext.java:33: error: TestExtensionContext is not abstract and does not override abstract method getExecutableInvoker() in ExtensionContext
public class TestExtensionContext implements ExtensionContext {

We should fix this and include JUnit 5.9 in our build.

@Michael1993
Copy link
Member

I guess we could implement it without the @Override annotation? Is that what you were thinking?

@Bukama
Copy link
Member

Bukama commented Aug 6, 2022

Final version of 5.9.0 was already released

@Bukama Bukama self-assigned this Aug 9, 2022
@Bukama
Copy link
Member

Bukama commented Aug 9, 2022

I'll give a try in spare time

@Bukama Bukama closed this as completed in bb212c5 Aug 28, 2022
Bukama added a commit to Bukama/junit-pioneer that referenced this issue Aug 28, 2022
Bukama added a commit to Bukama/junit-pioneer that referenced this issue Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants