Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle and pipeline when Java 18 is supported #613

Closed
Bukama opened this issue Mar 27, 2022 · 4 comments · Fixed by #651
Closed

Upgrade Gradle and pipeline when Java 18 is supported #613

Bukama opened this issue Mar 27, 2022 · 4 comments · Fixed by #651

Comments

@Bukama
Copy link
Member

Bukama commented Mar 27, 2022

As of writing Gradle does not support Java 18, according to: https://docs.gradle.org/current/userguide/compatibility.html

This means we can't upgrade our build pipeline to use it, which is what we want to

beatngu13: I mean once Gradle is ready for Java 18. What versions are we aiming for as part of our full build?
nipafx: 11, 17, 18

@aepfli
Copy link
Member

aepfli commented Mar 27, 2022

I am pretty sure we are not blocked here. There is a difference within our experimental build, regarding which version of java Gradle is using, and which one we are using for the actual build. Yes Gradle is not java 18 compatible, but it does not need to be. We only need to execute the build itself with 18 and Gradle with eg. 17

@beatngu13 beatngu13 added this to the Busy Pioneers - V2.0 milestone Apr 28, 2022
@nipafx nipafx removed this from To do in Pioneer 2.0 Apr 28, 2022
@Bukama
Copy link
Member Author

Bukama commented Jul 14, 2022

Java 18 is now supported by Gradle 7.5 according to the matrix

@beatngu13 beatngu13 self-assigned this Jul 14, 2022
@beatngu13
Copy link
Member

Regarding:

nipafx: 11, 17, 18

We currently "only" include 11 and 17:

https://github.com/junit-pioneer/junit-pioneer/blob/main/.github/workflows/build.yml#L120

Adding 18, not just replacing 17, will increase build time as we include an additional element to combine. Also, JUnit Jupiter 5.9.0-RC1 has been released:

https://junit.org/junit5/docs/snapshot/release-notes/#release-notes-5.9.0-RC1

Since we probably also want to include this version, we get another element to combine.

@nipafx
Copy link
Member

nipafx commented Sep 14, 2022

As you propose in #651, we should build against 18/19, though, so let's do that.

Bukama pushed a commit that referenced this issue Sep 19, 2022
…#659 / #651)

(Yes, this change does too much, but it all hangs together.)

Updates the Gradle wrapper version from 7.4 to 7.5 because that comes
with support for Java 18, which is also added to the build pipeline.
The experimental Java version is now (for another few days), Java 19.

The modular build is properly configured to really test from the
module path.

Furthermore, replaces the archived/deprecated GitHub action
sormuras/download-jdk with oracle-actions/setup-java.

Closes: #613, #659
PR: #651
Bukama pushed a commit to Bukama/junit-pioneer that referenced this issue Sep 20, 2022
…t-pioneer#613, junit-pioneer#659 / junit-pioneer#651)

(Yes, this change does too much, but it all hangs together.)

Updates the Gradle wrapper version from 7.4 to 7.5 because that comes
with support for Java 18, which is also added to the build pipeline.
The experimental Java version is now (for another few days), Java 19.

The modular build is properly configured to really test from the
module path.

Furthermore, replaces the archived/deprecated GitHub action
sormuras/download-jdk with oracle-actions/setup-java.

Closes: junit-pioneer#613, junit-pioneer#659
PR: junit-pioneer#651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment