Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up modular integration tests #596

Closed
beatngu13 opened this issue Feb 19, 2022 · 7 comments
Closed

Set up modular integration tests #596

beatngu13 opened this issue Feb 19, 2022 · 7 comments

Comments

@beatngu13
Copy link
Member

This issue stems from #539. To ensure Pioneer's compatability with JPMS, we have to set up modular integration tests and execute them during our build.

Open for discussion: should these tests be a separate module, a separate project, … ?

Helpful links:

@Bukama
Copy link
Member

Bukama commented Feb 26, 2022

I vote for @sormuras to implement that 👼

@Bukama
Copy link
Member

Bukama commented Apr 10, 2022

link to #617

@nipafx nipafx added this to the Busy Pioneers - V2.0 milestone Apr 28, 2022
@Bukama
Copy link
Member

Bukama commented May 12, 2022

@beatngu13 Is this still relevant, when upgrading to Java 11 (in #627)

@beatngu13
Copy link
Member Author

Yes, tests might pass on the class path, but fail on the module path.

@nipafx
Copy link
Member

nipafx commented May 25, 2022

@beatngu13 If you want, you can start a new branch based on #627 and start experimenting with the integration tests there.

@Bukama
Copy link
Member

Bukama commented Sep 25, 2022

@beatngu13 wasn't that also done with #651 ?

@beatngu13
Copy link
Member Author

@Bukama you are right, this should be done now. 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants