Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables and system properties not resetting after tests #579

Closed
Michael1993 opened this issue Jan 10, 2022 · 4 comments
Closed

Comments

@Michael1993
Copy link
Member

Opened retroactively for #578.

As seen in the PR, some tests do not reset the system property/environment variable they modified.
Is this unintended or intended behaviour?

@beatngu13
Copy link
Member

I guess this is my "fault".

The system property and environment variable test keys/values are completely made up, so when I wrote the tests for the system property extension — which I believe acted as a template for the environment variable tests — I thought resetting them is not necessary.

But yes, in the end the tests leave a dirty state behind.

@Bukama
Copy link
Member

Bukama commented Jan 16, 2022

So what's the solution @beatngu13 ?

@beatngu13
Copy link
Member

Besides making the tests a bit more verbose, #578 doesn't cause any harm and makes our tests less error-prone. So merging the PR is probably a good idea.

@beatngu13
Copy link
Member

beatngu13 commented Mar 24, 2022

Fixed via #578.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants