Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 17 instead of 16 in build #536

Merged
merged 3 commits into from Nov 11, 2021
Merged

Use Java 17 instead of 16 in build #536

merged 3 commits into from Nov 11, 2021

Conversation

beatngu13
Copy link
Member

Closes #521.

Gradle noob question: as described here, I ran the following command twice:

$ ./gradlew wrapper --gradle-version 7.3

The gradle-wrapper.jar and gradle executables, however, didn't change. Did I do something wrong?

Anyway, this PR should be merged after #535.

Proposed commit message:

Use Java 17 instead of 16 in build (#521 / #536)

Since this requires Gradle 7.3, this PR updates the Gradle wrapper
accordingly.

Closes: #521
PR: #536

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ;)

@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3-bin.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the executable and the jar sometimes simply do not change - the important part is, that the script and the jar download the new gradle version, and this is donewith this url change

@beatngu13 beatngu13 added the full-build Triggers full build suite on PR label Nov 11, 2021
@beatngu13 beatngu13 merged commit cef3ef5 into main Nov 11, 2021
@beatngu13 beatngu13 deleted the issue/521-java17-build branch November 11, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JDK 17 to the build matrix
3 participants