DisableIfArgument #368

Michael1993 · 2020-10-31T14:14:13Z

Closes #313

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

There is documentation (Javadoc and site documentation; added or updated)
There is implementation information to describe why a non-obvious source code / solution got implemented
Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
Only one sentence per line (especially in .adoc files)
Javadoc uses formal style, while sites documentation may use informal style (see Documentation: Personal or formal style #265)

Documentation (new extension)

The docs/docs-nav.yml navigation has an entry for the new extension
The package-info.java contains information about the new extension

Code

Code adheres to code style, naming conventions etc.
Successful tests cover all changes
There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks (see Require configuration failiure tests? #164)
Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

A prepared commit message exists
The list of contributions inside README.md mentions the new contribution (real name optional)

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

(no, not because this will make Sonar consider it 100% covered, why would you think that?) Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Bukama

Only minor things (no wonder after the stream ;) )

docs/disable-if-parameter.adoc

src/main/java/org/junitpioneer/jupiter/params/DisableIfParameterExtension.java

src/test/java/org/junitpioneer/jupiter/params/DisableIfParameterExtensionTests.java

src/main/java/org/junitpioneer/jupiter/params/DisableIfParameterExtension.java

src/main/java/org/junitpioneer/jupiter/params/DisableIfParameter.java

docs/docs-nav.yml

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

sonarcloud · 2020-11-10T18:57:56Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
0.0% Duplication

nipafx · 2020-11-10T20:45:40Z

Re documentation: There's a bit of textual and a lot of topical overlap between the two @DisableIf... extensions. Let's merge them into disable-parameterized-test-....adoc (with a similar title. But we need to keep disable-if-display-name.adoc around, so we don't break links. Let's just empty the file and point towards the new documentation.

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Bukama

LGTM (except merge conflict ;) )

Michael1993 · 2020-12-04T17:56:26Z

LGTM (except merge conflict ;) )

Sorry, could you take a look at the issue (#313)? There is an ongoing discussion there about why this PR is incomplete - I'd appreciate your input.

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

nipafx · 2020-12-22T20:29:52Z

I hope to have answered all your questions. :)

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

…cation-interceptor # Conflicts: # README.md # docs/docs-nav.yml # src/main/java/org/junitpioneer/jupiter/params/DisableIfNameExtension.java # src/test/java/org/junitpioneer/jupiter/params/DisabledIfNameExtensionTests.java

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Bukama · 2021-03-23T16:36:33Z

Just re-request my review if your done @Michael1993

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Michael1993 · 2021-03-23T17:52:23Z

Things still on TODO:

Add JavaDoc on annotations
~~Add new test file and gradle instructions to compile it with parameter naming information~~ If anyone better versed in gradle wants to do this, please, help me.

Bukama

I call this an approve as my comments are mostly personal point of view. I leave it up to you to update the docs.

Before merging we have to be aware of the placeholder

README.md

docs/disable-parameterized-tests.adoc

Bukama · 2021-03-24T14:32:13Z

docs/disable-parameterized-tests.adoc

+* The fourth invocation, because it has a parameter that matches ".*grew" - ends with grew.
+
+Just like with `contains`, if any parameter value matches any expression from `matches`, the invocation gets disabled.
+


I would add some kind of theader here, because the not is not a note for the particular example above

I don't know what you mean. Could you clarify?

For me I see some kind of break between line 244 (Just like..) and 246 (NOTE:) where the sentences are not connected by each other but from the formatting it seems like they belong together.

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Bukama · 2021-04-08T19:32:52Z

Can you update the branch with current main to run with the changed java/ JUnit versions please.

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

nipafx · 2021-05-18T20:15:35Z

Looks really good, great work! Some small changes aside, I renamed it from @DisableIfParameter etc to @DisableIfArgument etc because the conditions target arguments (i.e. the values passed for the parameters) and not the parameters themselves.

…into issue313/explore-invocation-interceptor

nipafx · 2021-05-29T12:03:45Z

We still need a commit message. 😬

Michael1993 added 11 commits September 26, 2020 09:14

Created PoC extension for disabling parameterized tests

d99e74b

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Merge branch 'master' into issue313/explore-invocation-interceptor

62bf604

Replaced value() with contains() and matches()

d223cfd

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Disable based on containing and RegEx

9574ea8

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Updated tests

0168cc1

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Spotless, no :(

c4e3576

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Add documentation based on DisableIfDisplayName

f9f46c8

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

README.md updated to include contribution

81fddd9

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Simplify orElseThrow

98663ed

(no, not because this will make Sonar consider it 100% covered, why would you think that?) Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Update tests to include a poem (Oscar Wilde: Requiescat)

2cfc8c1

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Update package-info.java with the new addition

b85e3e0

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Michael1993 marked this pull request as ready for review November 2, 2020 17:24

Michael1993 requested review from Bukama and beatngu13 November 2, 2020 17:24

Michael1993 added 2 commits November 2, 2020 18:25

Fix comma typo

5643ebf

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Add references to contribution

10e4d8a

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Bukama requested changes Nov 3, 2020

View reviewed changes

beatngu13 reviewed Nov 7, 2020

View reviewed changes

Update code and documentation according to feedback

bbe9dd0

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

nipafx mentioned this pull request Nov 10, 2020

Explore use of InvocationInterceptor to disable (parameterized) tests #313

Closed

In progress DisableIfParameter

26fdcb5

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Bukama approved these changes Dec 4, 2020

View reviewed changes

No parameters can not be disabled.

ff66f85

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Base automatically changed from master to main March 2, 2021 20:12

Michael1993 added 2 commits March 23, 2021 16:33

Update DisableIfParameter based on feedback

4b8d27b

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Update tests

b0e08e3

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Michael1993 added 3 commits March 23, 2021 18:16

Invalid input returns exception

8bb3765

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Invalid input returns exception, try #2

6903f5b

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Add another test

b6886d0

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Michael1993 requested review from Bukama and beatngu13 March 23, 2021 17:52

Bukama approved these changes Mar 24, 2021

View reviewed changes

Update docs

87637cb

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Michael1993 added 5 commits April 8, 2021 22:41

Merge branch 'main' into issue313/explore-invocation-interceptor

6c32440

Trigger checks again

cf6d5dc

Add JavaDoc on annotations

faf3d60

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

More JavaDoc updates

6d99b67

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Minor documentation polish

612030f

Signed-off-by: Mihaly Verhas <misi.verhas@gmail.com>

Michael1993 added this to In progress in Exploring Io Apr 20, 2021

Merge branch 'main' into issue313/explore-invocation-interceptor

b905274

nipafx removed this from In progress in Exploring Io Apr 28, 2021

beatngu13 mentioned this pull request May 14, 2021

Introduce extension API for accessing arguments passed to tests junit-team/junit5#1139

Open

Nicolai Parlog added 4 commits May 18, 2021 19:03

Merge branch 'main' into issue313/explore-invocation-interceptor

960051f

Edit documentation

76aa6d8

Moving code around

4fad9b5

Rename "Parameter" to "Argument"

058a1a2

Michael1993 changed the title ~~DisableIfParameter~~ DisableIfArgument May 19, 2021

Michael1993 added 2 commits May 29, 2021 13:47

Merge branch 'main' of https://github.com/junit-pioneer/junit-pioneer …

7f8c331

…into issue313/explore-invocation-interceptor

Add since in javadoc

27bd4fb

nipafx merged commit b49ff0a into junit-pioneer:main May 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DisableIfArgument #368

DisableIfArgument #368

Michael1993 commented Oct 31, 2020 •

edited

Bukama left a comment

sonarcloud bot commented Nov 10, 2020

nipafx commented Nov 10, 2020

Bukama left a comment •

edited

Michael1993 commented Dec 4, 2020

nipafx commented Dec 22, 2020

Bukama commented Mar 23, 2021

Michael1993 commented Mar 23, 2021 •

edited

Bukama left a comment

Bukama Mar 24, 2021

Michael1993 Apr 6, 2021

Bukama Apr 10, 2021

Bukama commented Apr 8, 2021

nipafx commented May 18, 2021

nipafx commented May 29, 2021

		* The fourth invocation, because it has a parameter that matches ".*grew" - ends with grew.

		Just like with `contains`, if any parameter value matches any expression from `matches`, the invocation gets disabled.

DisableIfArgument #368

DisableIfArgument #368

Conversation

Michael1993 commented Oct 31, 2020 • edited

Bukama left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Nov 10, 2020

nipafx commented Nov 10, 2020

Bukama left a comment • edited

Choose a reason for hiding this comment

Michael1993 commented Dec 4, 2020

nipafx commented Dec 22, 2020

Bukama commented Mar 23, 2021

Michael1993 commented Mar 23, 2021 • edited

Bukama left a comment

Choose a reason for hiding this comment

Bukama Mar 24, 2021

Choose a reason for hiding this comment

Michael1993 Apr 6, 2021

Choose a reason for hiding this comment

Bukama Apr 10, 2021

Choose a reason for hiding this comment

Bukama commented Apr 8, 2021

nipafx commented May 18, 2021

nipafx commented May 29, 2021

Michael1993 commented Oct 31, 2020 •

edited

Bukama left a comment •

edited

Michael1993 commented Mar 23, 2021 •

edited