Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run SonarCloud analysis with Java 11 #268

Merged
merged 1 commit into from May 26, 2020
Merged

Run SonarCloud analysis with Java 11 #268

merged 1 commit into from May 26, 2020

Conversation

beatngu13
Copy link
Member

@beatngu13 beatngu13 commented May 26, 2020

As pointed in issue #267, SonarCloud will drop support for Java 8 by October 2020. This PR will run the SonarCloud analysis with Java 11, while still using Java 8 source level. At least this is how I interpret the docs:

https://docs.sonarqube.org/latest/analysis/scan/sonarscanner-for-gradle/

Here it says sonar.java.source defaults to ${project.sourceCompatibility}, which we have set to 8 here:

https://github.com/junit-pioneer/junit-pioneer/blob/master/build.gradle.kts#L16

Proposed commit message:

Run SonarCloud analysis with Java 11

As pointed in issue #267, SonarCloud will drop support for Java 8 by
October 2020. This PR will run the SonarCloud analysis with Java 11,
while still using Java 8 source level.

Closes: #267
PR: #268

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

As pointed in issue #267, SonarCloud will drop support for Java 8 by October 2020. This PR will run the SonarCloud analysis with Java 11, while still using Java 8 source level.
@beatngu13 beatngu13 requested a review from aepfli May 26, 2020 19:21
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aepfli aepfli merged commit 79c4431 into junit-pioneer:master May 26, 2020
@aepfli
Copy link
Member

aepfli commented May 26, 2020

thank you!

@beatngu13 beatngu13 deleted the patch-1 branch May 26, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants