Bogus PR for Sonar experiments #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
We found out that GitHub Actions does not make secret tokens available to builds started in forks. This is a security feature and can be observed in the log output where only GitHub's token has a |
nipafx
pushed a commit
that referenced
this pull request
Mar 30, 2020
GitHub Actions does currently not allow to provide secrets for a workflow to a fork[1]. This means, SonarCloud works fine on branches and pull requests within the same repository, but not across forks as the forks will never know the sonar token. At the moment, the only way to achieve integration for all PRs is to hard-code the token into the workflow file for GitHub Actions. We could also add it to the Gradle script, but it makes more sense to keep it out of the build and in the CI configuration PR: #206 (and experiments in #207) Issue: no specific one, but belongs to #192 Related: 4f3647f [1] https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets#using-encrypted-secrets-in-a-workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental PR to make Sonar work.
I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.