Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing sonarcloud #206

Merged
merged 2 commits into from Mar 30, 2020
Merged

Fixing sonarcloud #206

merged 2 commits into from Mar 30, 2020

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Mar 29, 2020

As sonarcloud is currently not working, and
as long as we do not have time to proper
investigate we might want to deactivate it.


I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

As sonarcloud is currently not working, and
as long as we do not have time to proper
investigate we might want to deactivate it.
@nipafx
Copy link
Member

nipafx commented Mar 29, 2020

Any idea how long a proper fix would take? I don't mind having a "broken" project for a few days.

adding fixed token
@aepfli aepfli changed the title Deactivating sonarcloud Fixing sonarcloud Mar 29, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aepfli aepfli linked an issue Mar 29, 2020 that may be closed by this pull request
@aepfli
Copy link
Member Author

aepfli commented Mar 29, 2020

Issue:
It seems like GitHub Actions is currently not as advanced as Travis,
as it does not allow to provide Secrets for a workflow to a fork.

This means, sonarcloud works fine on branches and pullrequests within the same repository,
but not within forks. As the forks will never know the sonar token.

The only way to achieve this currently is by adding the token hardcoded into the
workflow file for GitHub Actions. We could also add it within the gradle script,
but i think it is better to keep it out of there and leave it just in the CI configuration

@nipafx nipafx merged commit 6fe755b into junit-pioneer:master Mar 30, 2020
@aepfli aepfli deleted the patch-3 branch March 31, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonarcloud analysis is not working
2 participants