Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docs with notes about documentation. #203

Merged
merged 6 commits into from Mar 30, 2020

Conversation

Bukama
Copy link
Member

@Bukama Bukama commented Mar 27, 2020

fixes #191


I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added some suggestions regarding wording and i think a link to the writers guide of asciidoctor might be really helpful

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Bukama and others added 3 commits March 28, 2020 17:28
Co-Authored-By: Simon Schrottner <simon.schrottner@gmail.com>
Co-Authored-By: Simon Schrottner <simon.schrottner@gmail.com>
Co-Authored-By: Simon Schrottner <simon.schrottner@gmail.com>
@nipafx
Copy link
Member

nipafx commented Mar 29, 2020

I made, err, "some changes". 😊 Let me know of there's anything amiss or should be changed back.

@Bukama
Copy link
Member Author

Bukama commented Mar 29, 2020

I made, err, "some changes". 😊 Let me know of there's anything amiss or should be changed back.

LGTM but I can't accept my (not so) own pull request ;)

@nipafx nipafx merged commit f62b769 into junit-pioneer:master Mar 30, 2020
@Bukama Bukama deleted the issue191/onelineasciidoc branch March 30, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend contributor docs about writing 1sentence per line
3 participants