Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

views are not available for TAB completion (seen on MS SQLServer) #470

Open
cdbruun opened this issue Feb 6, 2022 · 2 comments
Open

views are not available for TAB completion (seen on MS SQLServer) #470

cdbruun opened this issue Feb 6, 2022 · 2 comments

Comments

@cdbruun
Copy link

cdbruun commented Feb 6, 2022

Starting sqlline 1.12 with --fastconnect=false

Completion on table names work, but view names cannot be completed.

@cdbruun
Copy link
Author

cdbruun commented Feb 12, 2022

Checked out the source and figured out how to make VIEW completion work:

in DatabaseConnection.java (l. 281): add ,"VIEW" after "TABLE"
try (ResultSet rs = getDatabaseMetaData()
.getTables(getConnection().getCatalog(),
null, "%", new String[] {"TABLE", "VIEW"})) {

  • is there a reason why this is not always done ?

@julianhyde
Copy link
Owner

This makes sense. I can't imagine it breaking any drivers.

I wonder whether we could leave the table types blank (null, or whatever).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants