Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table width when containing unicode, fix crash due to min_width n… #64

Merged
merged 2 commits into from Nov 6, 2022
Merged

Fix table width when containing unicode, fix crash due to min_width n… #64

merged 2 commits into from Nov 6, 2022

Conversation

sftse
Copy link
Contributor

@sftse sftse commented Nov 2, 2022

…ot handling space for enumeration in lists, add some Debug impls

This html illustrates the fixes. With aaa this crashes with from_read(html, 80), with aa it does not but the layout is presumably not what was intended.

<!DOCTYPE html>
<html><body><table>
      <td><ol><li>a</li><li>နတမစ</li></ol></td>
      <td><ul><li>a</li><li>နတမစ</li></ul></td>
      <td><ol><li>aaa</li></ol></td>
</table></body></html>

Fix table width when containing unicode, fix crash due to min_width n…
37e84fa 
…ot handling space for enumeration in lists, add some Debug impls
@sftse sftse mentioned this pull request Nov 4, 2022
Closed
@jugglerchris
Copy link
Owner

Hi - thanks for the fix!
Do you mind adding a test with your test case please?
Otherwise it looks good. (Though I need to figure out why the CI hasn't run)

@jugglerchris
Copy link
Owner

Alternatively I'm happy to add the test case - let me know if it's ok to use your example.

@jugglerchris jugglerchris merged commit 141ff58 into jugglerchris:main Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sftse @jugglerchris