Small typo in basic_usage.md, convert relative links
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcliden
commented
Jan 25, 2022
| @@ -286,7 +286,7 @@ determine the absolute distance between numbers in those ranges: | |||
|
|
|||
| This is why our addition was unexpectedly rounded up: | |||
|
|
|||
| - `0.1` is in the range 0.0625 to 0.125, which are all `0.0625 f64::EPSILON` apart. | |||
| - `0.1` is in the range 0.0625 to 0.125, which are all `0.0625 * f64::EPSILON` apart. | |||
There was a problem hiding this comment.
This is the primary typo
|
Hello! And thank you, I am glad that you like it. Nice catch, I didn't realise you could effectively read the mdbook on github itself, that's pretty neat. Apologies if it takes a moment for me to figure out how to process your PR, it's the first one I've ever had! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃憢
I'm primarily submitting a small typo fix in
basic_usage.md.I was also reading the bare files in the repo and many of the relative links were broken due to the relative
*.htmllinks. I changed them to be primarily*.mdlinks, which work when browsing the bare repo and will compile into correct html links when the book is built. Mdbook suggests relative*.md*links in their docs here: https://rust-lang.github.io/mdBook/format/markdown.html?highlight=link#links .I didn't touch any of the/docs/links, since those aren't present in the repo before the build.I tested each of my changes locally using the included
./docs_build.batfile and the links all routed correctly.p.s. Thanks for this crate and it's wonderful documentation. I've really enjoyed reading through everything!