[Fix] jsx-no-target-blank: allow ternaries with literals
#3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
force-pushed
the
fix/jsx-no-target-blank-support-conditionals
branch
from
b91124c
to
8e55e8d
Compare
|
@akulsr0 i've freshly rebased this, but there's failing tests. |
|
I have moved the following testcase (which was failing) to valid, since it is a valid scenario. <a href={href} target={isExternal ? "_blank" : undefined} rel={isExternal ? "noopener noreferrer" : undefined} /> |
Codecov Report
@@ Coverage Diff @@
## master #3464 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 128 128
Lines 9110 9118 +8
Branches 3320 3321 +1
=======================================
+ Hits 8886 8894 +8
Misses 224 224
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ljharb
approved these changes
Oct 18, 2022
ljharb
force-pushed
the
fix/jsx-no-target-blank-support-conditionals
branch
from
590bde4
to
5efd774
Compare
ljharb
changed the title
jsx-no-target-blank support for conditionalsjsx-no-target-blank: allow ternaries with literals
ljharb
pushed a commit
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3462
I have added the fix for support of conditionals in
jsx-no-target-blankrule.But not sure about one test case and it's failing. Would need some help on that.
As per the test case this is expected to be invalid. I am not sure if this should be invalid or not?