Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-unknown-property: allow imageSrcSet and imageSizes attributes on <link> #3407

Conversation

terrymun
Copy link
Contributor

@terrymun terrymun commented Sep 5, 2022

This pull requests allows imageSrcSet and imageSizes on the <link /> element, as these properties are actually valid and allowed:

This is a fix for #3401

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #3407 (3306b92) into master (033fcc5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3407   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         123      123           
  Lines        8958     8958           
  Branches     3270     3270           
=======================================
  Hits         8742     8742           
  Misses        216      216           
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 98.83% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb force-pushed the allow-imagesrcset-imagesizes-on-link-element branch from 0c5a8a3 to 3306b92 Compare September 5, 2022 18:37
@ljharb ljharb changed the title fix: allow imageSrcSet and imageSizes attributes on link element [Fix] no-unknown-property: allow imageSrcSet and imageSizes attributes on <link> Sep 5, 2022
@terrymun
Copy link
Contributor Author

terrymun commented Sep 5, 2022

@ljharb No... thank you for looking into the PR so quickly. Sincerely appreciate the response time :)

@ljharb ljharb merged commit 3306b92 into jsx-eslint:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants