[Fix] no-unknown-property: onError and onLoad on <picture> and <iframe> elements #3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiis
changed the title
maiis
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3398 +/- ##
==========================================
- Coverage 97.58% 97.42% -0.17%
==========================================
Files 123 123
Lines 8958 8958
Branches 3270 3270
==========================================
- Hits 8742 8727 -15
- Misses 216 231 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Could you, please, also add 'onError' and 'onLoad' on <iframe> element? |
maiis
changed the title
Fixes #3410. Co-authored-by: Emmanuel Vuigner <hi@maiis.me> Co-authored-by: Aarni Koskela <akx@iki.fi>
This was referenced Sep 5, 2022
ljharb
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
onErrorandonLoadproperty on<picture>elementonErrorandonLoadproperty on<iframe>element