diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c7be04db4..3d70120af4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,10 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel * [`no-typos`]: avoid a crash on bindingless `prop-types` import; add warning ([#2899][] @ljharb) * [`jsx-curly-brace-presence`]: ignore containers with comments ([#2900][] @golopot) +### Changed +* [Docs] [`jsx-no-constructed-context-values`][]: fix invalid example syntax ([#2910][] @kud) + +[#2910]: https://github.com/yannickcr/eslint-plugin-react/pull/2910 [#2906]: https://github.com/yannickcr/eslint-plugin-react/pull/2906 [#2900]: https://github.com/yannickcr/eslint-plugin-react/pull/2900 [#2899]: https://github.com/yannickcr/eslint-plugin-react/issues/2899 diff --git a/docs/rules/jsx-no-constructed-context-values.md b/docs/rules/jsx-no-constructed-context-values.md index c0b79de23e..6816b98b59 100644 --- a/docs/rules/jsx-no-constructed-context-values.md +++ b/docs/rules/jsx-no-constructed-context-values.md @@ -23,7 +23,7 @@ return ( Examples of **correct** code for this rule: ``` -const foo = useMemo(() => {foo: 'bar'}, []); +const foo = useMemo(() => ({foo: 'bar'}), []); return ( ... @@ -34,4 +34,4 @@ return ( ## Legitimate Uses React Context, and all its child nodes and Consumers are rerendered whenever the value prop changes. Because each Javascript object carries its own *identity*, things like object expressions (`{foo: 'bar'}`) or function expressions get a new identity on every run through the component. This makes the context think it has gotten a new object and can cause needless rerenders and unintended consequences. -This can be a pretty large performance hit because not only will it cause the context providers and consumers to rerender with all the elements in its subtree, the processing for the tree scan react does to render the provider and find consumers is also wasted. \ No newline at end of file +This can be a pretty large performance hit because not only will it cause the context providers and consumers to rerender with all the elements in its subtree, the processing for the tree scan react does to render the provider and find consumers is also wasted.