From 78ddd46c9cce7001f31caa7d03fe263033edcdce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20Pavlid=C3=A8s?= Date: Fri, 10 Apr 2020 19:14:02 +0200 Subject: [PATCH] [Fix] `no-adjacent-inline-elements`: prevent crash on nullish children Fixes #2620 --- lib/rules/no-adjacent-inline-elements.js | 3 +++ tests/lib/rules/no-adjacent-inline-elements.js | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/lib/rules/no-adjacent-inline-elements.js b/lib/rules/no-adjacent-inline-elements.js index 28abeef0ba..bdddd79bef 100644 --- a/lib/rules/no-adjacent-inline-elements.js +++ b/lib/rules/no-adjacent-inline-elements.js @@ -84,6 +84,9 @@ module.exports = { function validate(node, children) { let currentIsInline = false; let previousIsInline = false; + if (!children) { + return; + } for (let i = 0; i < children.length; i++) { currentIsInline = isInline(children[i]); if (previousIsInline && currentIsInline) { diff --git a/tests/lib/rules/no-adjacent-inline-elements.js b/tests/lib/rules/no-adjacent-inline-elements.js index 21b0936362..ed3e91ddd4 100644 --- a/tests/lib/rules/no-adjacent-inline-elements.js +++ b/tests/lib/rules/no-adjacent-inline-elements.js @@ -69,6 +69,10 @@ ruleTester.run('no-adjacent-inline-elements', rule, { code: '
some text
;', parserOptions }, + { + code: 'React.createElement("div", null, "some text");', + parserOptions + }, { code: ('React.createElement("div", undefined, [React.createElement("a"), ' + '" some text ", React.createElement("a")]);'),