From da2c7d27f749f7e9849eaf4b6000cda4a80549f1 Mon Sep 17 00:00:00 2001
From: Chuan Ji <chuan@jichu4n.com>
Date: Fri, 11 Oct 2019 14:59:40 -0700
Subject: [PATCH] [Fix] `no-render-return-value`: should warn when used in
 assignment expression

Fixes #2461.
---
 lib/rules/no-render-return-value.js       |  3 ++-
 tests/lib/rules/no-render-return-value.js | 10 ++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/lib/rules/no-render-return-value.js b/lib/rules/no-render-return-value.js
index d0349f3e01..103887d441 100644
--- a/lib/rules/no-render-return-value.js
+++ b/lib/rules/no-render-return-value.js
@@ -58,7 +58,8 @@ module.exports = {
           parent.type === 'VariableDeclarator' ||
           parent.type === 'Property' ||
           parent.type === 'ReturnStatement' ||
-          parent.type === 'ArrowFunctionExpression'
+          parent.type === 'ArrowFunctionExpression' ||
+          parent.type === 'AssignmentExpression'
         ) {
           context.report({
             node: callee,
diff --git a/tests/lib/rules/no-render-return-value.js b/tests/lib/rules/no-render-return-value.js
index ab7c37190d..919da8b025 100644
--- a/tests/lib/rules/no-render-return-value.js
+++ b/tests/lib/rules/no-render-return-value.js
@@ -96,6 +96,16 @@ ruleTester.run('no-render-return-value', rule, {
     errors: [{
       message: 'Do not depend on the return value from ReactDOM.render'
     }]
+  }, {
+    code: 'this.o = ReactDOM.render(<div />, document.body);',
+    errors: [{
+      message: 'Do not depend on the return value from ReactDOM.render'
+    }]
+  }, {
+    code: 'var v; v = ReactDOM.render(<div />, document.body);',
+    errors: [{
+      message: 'Do not depend on the return value from ReactDOM.render'
+    }]
   }, {
     code: 'var inst = React.render(<div />, document.body);',
     settings: {