Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-no-leaked-render: Don't report errors on empty strings if React >= v18 #3488

Merged
merged 1 commit into from Nov 21, 2022
Merged

jsx-no-leaked-render: Don't report errors on empty strings if React >= v18 #3488

merged 1 commit into from Nov 21, 2022

Conversation

himanshu007-creator
Copy link
Contributor

resolves #3479

@codecov
Copy link

codecov bot commented Nov 14, 2022 •
edited

Codecov Report

Merging #3488 (c02d4e3) into master (12e9838) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3488   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         129      129           
  Lines        9209     9212    +3     
  Branches     3341     3342    +1     
=======================================
+ Hits         8986     8989    +3     
  Misses        223      223
Impacted Files Coverage Δ
lib/rules/jsx-no-leaked-render.js 98.50% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@himanshu007-creator himanshu007-creator marked this pull request as ready for review November 14, 2022 22:11
ljharb
ljharb requested changes Nov 16, 2022
View reviewed changes
lib/rules/jsx-no-leaked-render.js Outdated Show resolved Hide resolved
lib/rules/jsx-no-leaked-render.js Outdated Show resolved Hide resolved
lib/rules/jsx-no-leaked-render.js Outdated Show resolved Hide resolved
tests/lib/rules/jsx-no-leaked-render.js Show resolved Hide resolved
@ljharb ljharb mentioned this pull request Nov 16, 2022
Closed
@ljharb ljharb force-pushed the master branch 4 times, most recently from 069314a to 181c68f Compare November 18, 2022 17:19
ljharb
ljharb requested changes Nov 18, 2022
View reviewed changes
tests/lib/rules/jsx-no-leaked-render.js Outdated Show resolved Hide resolved
tests/lib/rules/jsx-no-leaked-render.js Show resolved Hide resolved
@ljharb ljharb force-pushed the himanshu-fix-jsx branch 2 times, most recently from 5668f9d to c02d4e3 Compare November 21, 2022 00:54
@ljharb ljharb merged commit c02d4e3 into jsx-eslint:master Nov 21, 2022
@ljharb ljharb mentioned this pull request Nov 21, 2022
Merged
@karlhorky karlhorky mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsx-no-leaked-render: Don't report errors on empty strings if React >= v18
2 participants
@himanshu007-creator @ljharb