Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-no-leaked-render: Don't report errors on empty strings if React >= v18 #3479

Closed
karlhorky opened this issue Nov 3, 2022 · 3 comments · Fixed by #3488
Closed

jsx-no-leaked-render: Don't report errors on empty strings if React >= v18 #3479

karlhorky opened this issue Nov 3, 2022 · 3 comments · Fixed by #3488
Labels
enhancement help wanted

Comments

@karlhorky
Copy link
Contributor

karlhorky commented Nov 3, 2022 •
edited

As mentioned and discussed here: #3203 (comment)

Modify the jsx-no-leaked-render rule to not report errors on empty strings if React is detected to be above or equal to v18, because React Native no longer throws on empty strings

Related docs PR: #3468
@karlhorky karlhorky mentioned this issue Nov 3, 2022
Merged
@himanshu007-creator
Copy link
Contributor

hey, is this issue resolved now, if not i would like to give it a shot

@ljharb
Copy link
Member

ljharb commented Nov 11, 2022

No, doesn’t seem to be. Go for it!

This was referenced Nov 14, 2022
Closed
Merged
@karlhorky
Copy link
Contributor Author

Thanks for #3488 @himanshu007-creator and @ljharb ! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
3 participants
@ljharb @karlhorky @himanshu007-creator