[Fix] sort-prop-types: avoid crash when autofixing
#3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
force-pushed
the
master
branch
6 times, most recently
from
59af733
to
865ed16
Compare
ljharb
force-pushed
the
ross-fix-sort-props-#3470
branch
from
27309f1
to
b40366d
Compare
|
@ROSSROSALES i think this needs to be rebased on latest, and i'm not sure of the best way to do it. Can you give it a try? |
|
I'll give it a try to rebase on latest |
ROSSROSALES
force-pushed
the
ross-fix-sort-props-#3470
branch
from
b40366d
to
e6a9c89
Compare
Codecov Report
@@ Coverage Diff @@
## master #3471 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 129 129
Lines 9212 9214 +2
Branches 3342 3341 -1
=======================================
+ Hits 8989 8991 +2
Misses 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ljharb
force-pushed
the
master
branch
4 times, most recently
from
069314a
to
181c68f
Compare
ROSSROSALES
force-pushed
the
ross-fix-sort-props-#3470
branch
from
e6a9c89
to
1ee5db8
Compare
ljharb
force-pushed
the
ross-fix-sort-props-#3470
branch
2 times, most recently
from
8799c44
to
668d54f
Compare
ljharb
approved these changes
Nov 27, 2022
ljharb
force-pushed
the
ross-fix-sort-props-#3470
branch
from
668d54f
to
4243dcc
Compare
ljharb
changed the title
sort-prop-types: avoid crash when autofixing
ljharb
force-pushed
the
ross-fix-sort-props-#3470
branch
from
4243dcc
to
cc9578c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3470
Now rule respects multiple comments before and after prop.
Fixes issue of no comments before and after prop not being considered during parsing.