Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of empty strings for React 18 #3468

Merged
merged 1 commit into from Nov 21, 2022
Merged

Remove mentions of empty strings for React 18 #3468

merged 1 commit into from Nov 21, 2022

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Oct 19, 2022

Ref: #3203 (comment)

Also cleans up some formatting in the JSX examples

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #3468 (dfd64ae) into master (c02d4e3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3468   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         129      129           
  Lines        9212     9212           
  Branches     3342     3342           
=======================================
  Hits         8989     8989           
  Misses        223      223           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@karlhorky
Copy link
Contributor Author

@ljharb what do you think about this one? Or is this approach with this first docs PR not what you had in mind?

@ljharb
Copy link
Member

ljharb commented Nov 21, 2022

With the merging of #3488, the behavior is now corrected for the React version as well.

@ljharb ljharb merged commit dfd64ae into jsx-eslint:master Nov 21, 2022
@karlhorky
Copy link
Contributor Author

Great, thanks!

@karlhorky karlhorky deleted the patch-1 branch November 22, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants