Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialog element onClose has react/no-unknown-property #3436

Closed
rpearce opened this issue Sep 17, 2022 · 3 comments
Closed

dialog element onClose has react/no-unknown-property #3436

rpearce opened this issue Sep 17, 2022 · 3 comments
Labels
bug

Comments

@rpearce
Copy link

rpearce commented Sep 17, 2022

The <dialog> element has a close event, and with a recent update to this package (somewhere between 7.31.0 and 7.31.8), it seems that <dialog onClose is now triggering react/no-unknown-property.

Was this something that was intentionally done? If so, and if y'all have time, could you help me understand the thinking behind it?

Thanks for your time!
@ljharb
Copy link
Member

ljharb commented Sep 17, 2022

Nope, just a bug. Thanks for reporting.

@ljharb ljharb closed this as completed in b52e0ca Sep 17, 2022
@ljharb
Copy link
Member

ljharb commented Sep 17, 2022

This was broken in v7.31.2, and will be fixed in v7.31.9 once it's released (which i plan to do in the next day or three).

@ljharb ljharb added the bug label Sep 17, 2022
@rpearce
Copy link
Author

rpearce commented Sep 17, 2022

Thank you! 🎉

@yanagi0602 yanagi0602 mentioned this issue Nov 25, 2022
Merged
1 task
@lanberb lanberb mentioned this issue Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @rpearce