Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] display-name: fix false positive for assignment of function returning null #3331

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

apbarrero
Copy link
Contributor

Fixes #3329

Stop considering let any; any = () => null as a component.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #3331 (3963193) into master (f7fe38f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3331   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         123      123           
  Lines        8783     8787    +4     
  Branches     3188     3190    +2     
=======================================
+ Hits         8582     8586    +4     
  Misses        201      201           
Impacted Files Coverage Δ
lib/util/Components.js 98.92% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fe38f...3963193. Read the comment docs.

@ljharb ljharb changed the title [Fix] display-name: fix false positive for assignment of function returning null [Fix] display-name: fix false positive for assignment of function returning null Jul 12, 2022
@ljharb ljharb merged commit 3963193 into jsx-eslint:master Jul 12, 2022
@boonya
Copy link

boonya commented Sep 5, 2022

Hey guys, I am still experiencing the issue. Even on 7.31.6. Do you have any ideas?

@ljharb
Copy link
Member

ljharb commented Sep 5, 2022

@boonya can you file a new issue?

@boonya
Copy link

boonya commented Sep 5, 2022

@boonya can you file a new issue?

Here it is #3412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

False positive for react/display-name on function value assignment
3 participants