Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] button-has-type: fix exception for <button type> #3255

Merged
merged 1 commit into from May 16, 2022

Conversation

meowtec
Copy link
Contributor

@meowtec meowtec commented Mar 23, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #3255 (458ebfc) into master (2145e29) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3255      +/-   ##
==========================================
- Coverage   97.67%   97.51%   -0.17%     
==========================================
  Files         121      121              
  Lines        8575     8575              
  Branches     3112     3112              
==========================================
- Hits         8376     8362      -14     
- Misses        199      213      +14     
Impacted Files Coverage Δ
lib/rules/button-has-type.js 96.77% <100.00%> (ø)
lib/rules/no-unused-state.js 93.43% <0.00%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2145e29...458ebfc. Read the comment docs.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #3255 (9356230) into master (46ce117) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3255   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         123      123           
  Lines        8728     8728           
  Branches     3161     3161           
=======================================
  Hits         8528     8528           
  Misses        200      200           
Impacted Files Coverage Δ
lib/rules/button-has-type.js 96.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ce117...9356230. Read the comment docs.

@ljharb ljharb merged commit 9356230 into jsx-eslint:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants