Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] no-unknown-property: Allow crossOrigin on image tag (SVG) #3251

Merged
merged 1 commit into from Mar 21, 2022
Merged

[New] no-unknown-property: Allow crossOrigin on image tag (SVG) #3251

merged 1 commit into from Mar 21, 2022

Conversation

zpao
Copy link
Contributor

@zpao zpao commented Mar 21, 2022

Fixes #3250

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022 •
edited

Codecov Report

Merging #3251 (2145e29) into master (567bc7d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3251   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files         121      121           
  Lines        8575     8575           
  Branches     3112     3112           
=======================================
  Hits         8376     8376           
  Misses        199      199
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 96.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567bc7d...2145e29. Read the comment docs.

ljharb
ljharb approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb changed the title Allow crossOrigin on image tag (SVG) in no-unknown-properties [New] no-unknown-property: Allow crossOrigin on image tag (SVG) Mar 21, 2022
@ljharb ljharb merged commit 2145e29 into jsx-eslint:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-unknown-property does not allow crossOrigin on svg elements
3 participants
@zpao @codecov-commenter @ljharb