Improve no-unstable-nested-components error message and catch React.memo() #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h React.memo() Fixes jsx-eslint#3231
ljharb
force-pushed
the
zach/unstable-memo-message
branch
from
a72ed42
to
1fdf9bd
Compare
ljharb
approved these changes
May 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #3247 +/- ##
==========================================
+ Coverage 97.67% 97.68% +0.01%
==========================================
Files 123 123
Lines 8736 8734 -2
Branches 3164 3163 -1
==========================================
- Hits 8533 8532 -1
+ Misses 203 202 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3231.
The bugfix itself is just one line since
React.memowrappers are already being detected as components; this plugin just wasn't searching forCallExpressions.I've also updated the error message to be more specific about the recommended fix. Technically this can also be fixed by calling the function directly (
renderComponent(props)vs<Component {...props} />) but I'm not sure if we want to squeeze that into the error message.Memoizing with
useCallback()is not generally safe since the returned function isn't guaranteed to be stable, even if the deps are empty. I have a branch that can detect this, but that probably has other consequences so I'll leave it to a separate PR.