[New] destructuring-assignment: add option destructureInSignature
#3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3235 +/- ##
==========================================
- Coverage 97.69% 97.67% -0.02%
==========================================
Files 121 121
Lines 8554 8575 +21
Branches 3100 3112 +12
==========================================
+ Hits 8357 8376 +19
- Misses 197 199 +2
Continue to review full report at Codecov.
|
golopot
force-pushed
the
destruct-at-parameter
branch
from
5fb7b13
to
d5e0fda
Compare
ljharb
reviewed
Mar 7, 2022
| @@ -104,3 +104,33 @@ class Foo extends React.PureComponent { | |||
| bar = this.props.bar | |||
| } | |||
| ``` | |||
|
|
|||
| ### `destructAtParameter` (default: "ignore") | |||
There was a problem hiding this comment.
maybe destructureInSignature is better? "destruct" implies it's destroying it, and "parameter" is technically correct but often confused with "argument"
There was a problem hiding this comment.
My English destructs.
golopot
force-pushed
the
destruct-at-parameter
branch
from
cf4eaa1
to
ef8c784
Compare
ljharb
changed the title
destructuring-assignment: add option destructAtParameterdestructuring-assignment: add option destructureInSignature
ljharb
force-pushed
the
destruct-at-parameter
branch
from
ef8c784
to
567bc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3232.