You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the example above, optionProps.value === props.maxSelectableValue emits a react/prop-types warning,
although a prop-type validation was defined for maxSelectableValue.
I'm not sure if I should file this as a bug. I was looking through the changelogs and previous PR and discussions up to v7.21.2 and couldn't find hints as to how I can migrate this. I welcome suggestions, clarity if this is be design and what I can do next.
What I expected
react/prop-types to not emit warning for props.maxSelectableValue for the case above.
context information:
SelectInput is a component of an external library that I import. It wraps react-select
Note that the config for @commercetools-frontend/eslint-config-nc-appcan be found here
off topic:
Regarding react/display-name, I stumbled on cases where disabling it still emits warnings (not in this scenario)
I'll create a different issue for that, if I can't resolve it
The text was updated successfully, but these errors were encountered:
Hey.
I attempted to upgrade
eslint-plugin-react
in my repo fromv7.20.6
tov7.21.2
,and
react/prop-types
rule emits warnings.Actual source code (simplest case)
In the example above,
optionProps.value === props.maxSelectableValue
emits areact/prop-types
warning,although a prop-type validation was defined for
maxSelectableValue
.I'm not sure if I should file this as a bug. I was looking through the changelogs and previous PR and discussions up to
v7.21.2
and couldn't find hints as to how I can migrate this. I welcome suggestions, clarity if this is be design and what I can do next.What I expected
react/prop-types
to not emit warning forprops.maxSelectableValue
for the case above.context information:
SelectInput
is a component of an external library that I import. It wraps react-selectconfiguration
base configuration
Note that the config for
@commercetools-frontend/eslint-config-nc-app
can be found hereoff topic:
Regarding
react/display-name
, I stumbled on cases where disabling it still emits warnings (not in this scenario)I'll create a different issue for that, if I can't resolve it
The text was updated successfully, but these errors were encountered: