Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for jsx-indent in plain JS #2565

Closed
amneacsu opened this issue Feb 3, 2020 · 2 comments · Fixed by #2564
Closed

False positive for jsx-indent in plain JS #2565

amneacsu opened this issue Feb 3, 2020 · 2 comments · Fixed by #2564

Comments

@amneacsu
Copy link

amneacsu commented Feb 3, 2020

After upgrade from 17.8.0 to 17.8.2, jsx-indent now complains for plain strings in plain JS files. I was expecting eslint-plugin-react to ignore this file, as it's not importing React or using JSX.

// somefile.js
const foo = {
  bar: 'baz1\nbaz2'
       ^ Expected indentation of 4 space characters but found 0
};
@amneacsu
Copy link
Author

amneacsu commented Feb 3, 2020

Fixed in 17.8.3.

@amneacsu amneacsu closed this as completed Feb 3, 2020
@ljharb
Copy link
Member

ljharb commented Feb 3, 2020

Duplicate of #2563.

@ljharb ljharb linked a pull request Feb 3, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants