Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] add sort-default-props and deprecate jsx-sort-default-props #1861

Merged
merged 1 commit into from Oct 10, 2022

Conversation

alexzherdev
Copy link
Contributor

@alexzherdev alexzherdev commented Jun 29, 2018

Pt. 1 of #1834

@alexzherdev
Copy link
Contributor Author

alexzherdev commented Jun 29, 2018

Looks like I need to fix #1817 to improve coverage.
Edit: done

@alexzherdev alexzherdev force-pushed the rename-jsx-sort-default-props branch from 4dc8c4d to e212430 Compare June 30, 2018 02:35
@alexzherdev alexzherdev force-pushed the rename-jsx-sort-default-props branch from e212430 to 8d775a6 Compare July 3, 2018 04:57
@alexzherdev
Copy link
Contributor Author

Just rebased to resolve conflicts

@VincentLanglet
Copy link
Contributor

If my PR is merged before yours, you'll have to add my bug fix.
#2182

@VincentLanglet
Copy link
Contributor

@alexzherdev Since my PR #2182 was merged, you have to update the new sort-default-props, or you'll lose the fix I made.

Thanks ;)

@amannn
Copy link

amannn commented Jul 5, 2019

What's the status of this? Looks like this PR was approved and the only thing left to do is to copy over the bugfix mentioned above.

@ljharb
Copy link
Member

ljharb commented Jul 5, 2019

ping @alexzherdev

@alexzherdev alexzherdev force-pushed the rename-jsx-sort-default-props branch 2 times, most recently from fa02359 to bbb029b Compare July 6, 2019 05:27
@alexzherdev
Copy link
Contributor Author

Done

@ljharb ljharb marked this pull request as draft February 6, 2022 07:24
@ljharb ljharb force-pushed the rename-jsx-sort-default-props branch from 56ba1c0 to 61c369c Compare September 30, 2022 20:27
@ljharb ljharb changed the title Add sort-default-props and deprecate jsx-sort-default-props [New] add sort-default-props and deprecate jsx-sort-default-props Sep 30, 2022
@ljharb ljharb added new rule and removed rule labels Sep 30, 2022
@ljharb ljharb removed the request for review from yannickcr September 30, 2022 20:28
@ljharb ljharb removed the request for review from lencioni September 30, 2022 20:28
@ljharb ljharb marked this pull request as ready for review September 30, 2022 20:29
@ljharb
Copy link
Member

ljharb commented Sep 30, 2022

This looks good, but I'm going to cut a patch release before merging semver-minor items.

@ljharb ljharb force-pushed the rename-jsx-sort-default-props branch from 61c369c to 323f63f Compare September 30, 2022 23:37
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #1861 (feae3bc) into master (c3d3e25) will decrease coverage by 0.04%.
The diff coverage is 91.04%.

@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
- Coverage   97.63%   97.58%   -0.05%     
==========================================
  Files         123      124       +1     
  Lines        8988     9055      +67     
  Branches     3288     3308      +20     
==========================================
+ Hits         8775     8836      +61     
- Misses        213      219       +6     
Impacted Files Coverage Δ
index.js 100.00% <ø> (ø)
lib/rules/sort-default-props.js 90.00% <90.00%> (ø)
lib/rules/jsx-sort-default-props.js 91.04% <100.00%> (+1.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants