New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] add sort-default-props
and deprecate jsx-sort-default-props
#1861
[New] add sort-default-props
and deprecate jsx-sort-default-props
#1861
Conversation
|
4dc8c4d
to
e212430
Compare
e212430
to
8d775a6
Compare
8d775a6
to
32cb939
Compare
Just rebased to resolve conflicts |
32cb939
to
c7fa863
Compare
If my PR is merged before yours, you'll have to add my bug fix. |
@alexzherdev Since my PR #2182 was merged, you have to update the new sort-default-props, or you'll lose the fix I made. Thanks ;) |
What's the status of this? Looks like this PR was approved and the only thing left to do is to copy over the bugfix mentioned above. |
ping @alexzherdev |
fa02359
to
bbb029b
Compare
Done |
56ba1c0
to
61c369c
Compare
sort-default-props
and deprecate jsx-sort-default-props
This looks good, but I'm going to cut a patch release before merging semver-minor items. |
61c369c
to
323f63f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1861 +/- ##
==========================================
- Coverage 97.63% 97.58% -0.05%
==========================================
Files 123 124 +1
Lines 8988 9055 +67
Branches 3288 3308 +20
==========================================
+ Hits 8775 8836 +61
- Misses 213 219 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
323f63f
to
feae3bc
Compare
Pt. 1 of #1834