Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soft deprecation for jsx-space-before-closing #1137

Closed
dnalborczyk opened this issue Mar 31, 2017 · 4 comments
Closed

soft deprecation for jsx-space-before-closing #1137

dnalborczyk opened this issue Mar 31, 2017 · 4 comments

Comments

@dnalborczyk
Copy link

dnalborczyk commented Mar 31, 2017

The introduction of jsx-tag-spacing makes jsx-space-before-closing obsolete.

#1070
#693 (comment)

since the plan is to deprecate jsx-space-before-closing, I think it would be already helpful and less confusing - as it was for me - if this would be already mentioned in the docs.

something like:

Note: This rule will be deprecated in the next major release. Consider using jsx-tag-spacing instead.

Mind if I do a PR?

@ljharb
Copy link
Member

ljharb commented Apr 1, 2017

Sounds great!

You can also mark the rule itself as deprecated in its metadata.

@tleunen
Copy link

tleunen commented May 4, 2017

I believe this is a must have. Because if a project has both configuration, with different settings, eslint will keep complaining that there's an error.

@alexzherdev
Copy link
Contributor

@ljharb
Copy link
Member

ljharb commented Jul 2, 2018

Closed with #1070.

@ljharb ljharb closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants