From 3dd1215ffbf626990625dca753fce2b12c0c9abb Mon Sep 17 00:00:00 2001 From: himanshu007-creator Date: Tue, 15 Nov 2022 02:32:19 +0530 Subject: [PATCH] fix: remove error reporting for empty string for react >=v18 --- lib/rules/jsx-no-leaked-render.js | 16 +++++++++------- tests/lib/rules/jsx-no-leaked-render.js | 2 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/rules/jsx-no-leaked-render.js b/lib/rules/jsx-no-leaked-render.js index efea6a63c4..e7b45da04b 100644 --- a/lib/rules/jsx-no-leaked-render.js +++ b/lib/rules/jsx-no-leaked-render.js @@ -7,6 +7,7 @@ const docsUrl = require('../util/docsUrl'); const report = require('../util/report'); +const { testReactVersion } = require('../util/version'); const isParenthesized = require('../util/ast').isParenthesized; //------------------------------------------------------------------------------ @@ -129,13 +130,14 @@ module.exports = { return; } } - - report(context, messages.noPotentialLeakedRender, 'noPotentialLeakedRender', { - node, - fix(fixer) { - return ruleFixer(context, fixStrategy, fixer, node, leftSide, node.right); - }, - }); + if(!testReactVersion(context, '>= 18.0.0') && !(node.left.value == '')){ + report(context, messages.noPotentialLeakedRender, 'noPotentialLeakedRender', { + node, + fix(fixer) { + return ruleFixer(context, fixStrategy, fixer, node, leftSide, node.right); + }, + }); + } }, 'JSXExpressionContainer > ConditionalExpression'(node) { diff --git a/tests/lib/rules/jsx-no-leaked-render.js b/tests/lib/rules/jsx-no-leaked-render.js index 032d8eadfb..affce9d0e1 100644 --- a/tests/lib/rules/jsx-no-leaked-render.js +++ b/tests/lib/rules/jsx-no-leaked-render.js @@ -232,7 +232,7 @@ ruleTester.run('jsx-no-leaked-render', rule, { return ( <> {0 ? : null} - {'' ? : null} + {'' && } {NaN ? : null} )