Skip to content

Latest commit

 

History

History
66 lines (52 loc) · 1.3 KB

no-redundant-should-component-update.md

File metadata and controls

66 lines (52 loc) · 1.3 KB

Disallow usage of shouldComponentUpdate when extending React.PureComponent (react/no-redundant-should-component-update)

💼 This rule is enabled in the following configs: all.

Warns if you have shouldComponentUpdate defined when defining a component that extends React.PureComponent. While having shouldComponentUpdate will still work, it becomes pointless to extend PureComponent.

Rule Details

Examples of incorrect code for this rule:

class Foo extends React.PureComponent {
  shouldComponentUpdate() {
    // do check
  }

  render() {
    return <div>Radical!</div>
  }
}

function Bar() {
  return class Baz extends React.PureComponent {
    shouldComponentUpdate() {
      // do check
    }

    render() {
      return <div>Groovy!</div>
    }
  }
}

Examples of correct code for this rule:

class Foo extends React.Component {
  shouldComponentUpdate() {
    // do check
  }

  render() {
    return <div>Radical!</div>
  }
}

function Bar() {
  return class Baz extends React.Component {
    shouldComponentUpdate() {
      // do check
    }

    render() {
      return <div>Groovy!</div>
    }
  }
}

class Qux extends React.PureComponent {
  render() {
    return <div>Tubular!</div>
  }
}