From ce2c32855defdc64515b8c5200a7a49b99d0c671 Mon Sep 17 00:00:00 2001
From: uncommon-type <uncommon.type@rambler.ru>
Date: Fri, 15 Apr 2022 14:04:01 +0300
Subject: [PATCH] [Fix] `no-redundant-roles`, `role-supports-aria-props`:
 Remove implicit role from dl element

- Add a valid test case indicating `list` as a valid role for dl
- Remove dl import and export from implicitRoles` index.js file
- Remove dl.js form implicitRoles folder

Fixes #847
---
 __tests__/src/rules/no-redundant-roles-test.js       | 1 +
 __tests__/src/rules/role-supports-aria-props-test.js | 4 ----
 src/util/implicitRoles/dl.js                         | 6 ------
 src/util/implicitRoles/index.js                      | 2 --
 4 files changed, 1 insertion(+), 12 deletions(-)
 delete mode 100644 src/util/implicitRoles/dl.js

diff --git a/__tests__/src/rules/no-redundant-roles-test.js b/__tests__/src/rules/no-redundant-roles-test.js
index 27e5f9c9d..786bdf858 100644
--- a/__tests__/src/rules/no-redundant-roles-test.js
+++ b/__tests__/src/rules/no-redundant-roles-test.js
@@ -77,6 +77,7 @@ ruleTester.run(`${ruleName}:recommended (valid list role override)`, rule, {
   valid: [
     { code: '<ul role="list" />' },
     { code: '<ol role="list" />' },
+    { code: '<dl role="list" />' },
   ]
     .map(ruleOptionsMapperFactory(listException))
     .map(parserOptionsMapper),
diff --git a/__tests__/src/rules/role-supports-aria-props-test.js b/__tests__/src/rules/role-supports-aria-props-test.js
index 8593ab641..6d1cc88e6 100644
--- a/__tests__/src/rules/role-supports-aria-props-test.js
+++ b/__tests__/src/rules/role-supports-aria-props-test.js
@@ -432,10 +432,6 @@ ruleTester.run('role-supports-aria-props', rule, {
       code: '<dialog aria-expanded />',
       errors: [errorMessage('aria-expanded', 'dialog', 'dialog', true)],
     },
-    {
-      code: '<dl aria-expanded />',
-      errors: [errorMessage('aria-expanded', 'list', 'dl', true)],
-    },
     {
       code: '<aside aria-expanded />',
       errors: [errorMessage('aria-expanded', 'complementary', 'aside', true)],
diff --git a/src/util/implicitRoles/dl.js b/src/util/implicitRoles/dl.js
deleted file mode 100644
index c2ab06aa5..000000000
--- a/src/util/implicitRoles/dl.js
+++ /dev/null
@@ -1,6 +0,0 @@
-/**
- * Returns the implicit role for a dl tag.
- */
-export default function getImplicitRoleForDl() {
-  return 'list';
-}
diff --git a/src/util/implicitRoles/index.js b/src/util/implicitRoles/index.js
index 6f1bfde2d..027b62af4 100644
--- a/src/util/implicitRoles/index.js
+++ b/src/util/implicitRoles/index.js
@@ -7,7 +7,6 @@ import button from './button';
 import datalist from './datalist';
 import details from './details';
 import dialog from './dialog';
-import dl from './dl';
 import form from './form';
 import h1 from './h1';
 import h2 from './h2';
@@ -46,7 +45,6 @@ export default {
   datalist,
   details,
   dialog,
-  dl,
   form,
   h1,
   h2,