Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentation and tests cases for allowExpressionValues option #870

Merged
merged 3 commits into from Jul 7, 2022

Conversation

V2dha
Copy link
Contributor

@V2dha V2dha commented Jul 7, 2022

Fixes 867

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #870 (1640f04) into main (f0e04ce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1640f04 differs from pull request most recent head 0c19f02. Consider uploading reports for the commit 0c19f02 to get more accurate results

@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   99.25%   99.26%           
=======================================
  Files          98       98           
  Lines        1481     1488    +7     
  Branches      487      492    +5     
=======================================
+ Hits         1470     1477    +7     
  Misses         11       11           
Impacted Files Coverage Δ
src/rules/no-noninteractive-tabindex.js 97.36% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0e04ce...0c19f02. Read the comment docs.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@ljharb ljharb merged commit 0c19f02 into jsx-eslint:main Jul 7, 2022
@V2dha V2dha deleted the allow-expression-values branch July 8, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document allowExpressionValues option
2 participants