[Fix] no-static-element-interactions: allow role assignments using a ternary with literals on both sides

[V2dha]

Fixes 766

[codecov]

Codecov Report

Merging #865 (5285b91) into main (2362832) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5285b91 differs from pull request most recent head 7524e0c. Consider uploading reports for the commit 7524e0c to get more accurate results

@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          98       98           
  Lines        1474     1481    +7     
  Branches      482      487    +5     
=======================================
+ Hits         1463     1470    +7     
  Misses         11       11           

Impacted Files	Coverage Δ
src/rules/no-static-element-interactions.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2362832...7524e0c. Read the comment docs.

[ljharb]

I rebased this and added a test case, which fails both without your fix and with it.

[V2dha]

@ljharb Can you review the code that I added once? I feel like it is not able to access the prop value of the role attribute? Does the getPropValue function only returns the value and not the node of the prop?

[ljharb]

It kind of seems like getProp(attributes, 'role') returns a JSXAttribute node, and getPropValue is returning "button", so you can't figure out that it's a conditional expression?

[ljharb]

@V2dha i pushed up a commit that i think will fix it; what do you think?

I also filed #867 since the allowExpressionValues option is undocumented.

[V2dha]

Thanks for the fix! Tests are passing locally now. I tried using getProp function earlier as well but it was throwing error while getting its type maybe because it was returning a JSXAttribute node.