Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm run test. Update import as import type. Replace script - flow… #856

Merged
merged 1 commit into from Jun 2, 2022
Merged

Fix npm run test. Update import as import type. Replace script - flow… #856

merged 1 commit into from Jun 2, 2022

Conversation

inspiraller
Copy link

@inspiraller inspiraller commented Jun 2, 2022 •
edited by ljharb

Fixes #855

@ljharb
[Tests] Fix npm run flow
287854a 
 - Update import as import type
 - Replace script - flow with just flow (removing if statement)
 - Adding ignore script for malformed node_modules file
@codecov
Copy link

codecov bot commented Jun 2, 2022 •
edited

Codecov Report

Merging #856 (287854a) into main (112261c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          98       98           
  Lines        1474     1474           
  Branches      482      482           
=======================================
  Hits         1463     1463           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112261c...287854a. Read the comment docs.

@inspiraller inspiraller mentioned this pull request Jun 2, 2022
Closed
ljharb
ljharb approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i like that this is a simplification/improvement unrelated to Windows, that just happens to remove the unix-specific parts of the script.

@ljharb ljharb merged commit 287854a into jsx-eslint:main Jun 2, 2022
@V2dha V2dha mentioned this pull request Jun 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running test on windows fails
2 participants
@inspiraller @ljharb