Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-redundant-roles, role-supports-aria-props: Remove implicit role from dl element #848

Merged
merged 1 commit into from Apr 15, 2022

Conversation

uncommon-type
Copy link
Contributor

@uncommon-type uncommon-type commented Apr 15, 2022

Description

According to the W3 documentation, there is no implicit role for dl. This PR removes the code stating there is an implicit role of list for definition lists from the no-redundant-roles-test.js file.

Related Issue

Closes #847

Acceptance Criteria

  • Add a test case indicating list as a valid role for dl
  • Remove dl import and export from implicitRoles’ index.js file
  • Remove dl.js form implicitRoles folder

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

…it role from dl element

- Add a valid test case indicating `list` as a valid role for dl
- Remove dl import and export from implicitRoles` index.js file
- Remove dl.js form implicitRoles folder

Fixes jsx-eslint#847
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #848 (ce2c328) into main (f6ba03c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   99.25%   99.25%   -0.01%     
==========================================
  Files          99       98       -1     
  Lines        1476     1474       -2     
  Branches      482      482              
==========================================
- Hits         1465     1463       -2     
  Misses         11       11              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ba03c...ce2c328. Read the comment docs.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The slight coverage decrease isn't a big deal.

@ljharb ljharb changed the title [fix] Remove implicit role from dl element [Fix] no-redundant-roles, role-supports-aria-props: Remove implicit role from dl element Apr 15, 2022
@ljharb ljharb merged commit ce2c328 into jsx-eslint:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DL should not have implicit list role
2 participants