[fix]: Fix optional chaining bug in img-redundant-alt rule #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test cases with optional chaining - Add parserOptions prop to each test case to configure parser behaviour Closes jsx-eslint#794
Codecov Report
@@ Coverage Diff @@
## main #832 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 98 98
Lines 1419 1419
Branches 479 479
=======================================
Hits 1408 1408
Misses 11 11 Continue to review full report at Codecov.
|
ljharb
requested changes
Feb 21, 2022
ljharb
force-pushed
the
issue794-optional-chaining-bug
branch
from
d2c35b6
to
ea877c4
Compare
ljharb
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an optional chaining bug in the
img-redundant-altrule. It adds valid test cases with optional chaining operator to theimg-redundant-alt-testfile and makes sure they have aparserOptionsproperty for configuring parser behaviour. Along with that, it addssemver@6to ensure that tests using optional chaining skip eslint < 6Related Issue
Closes #794
Acceptance Criteria
Type of Changes