New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added allowedInvalidRoles option to aria-role #828
Added allowedInvalidRoles option to aria-role #828
Conversation
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 98 98
Lines 1417 1419 +2
Branches 477 479 +2
=======================================
+ Hits 1406 1408 +2
Misses 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments
Ping @ljharb - could I request a re-review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
1df7f13
to
566011b
Compare
Any idea when this will be published? |
Nope, no idea. It will be included in the next release, whenever that is. |
It would be lovely to get a (+ A bit confusing to find the option in the official docs but not be able to use it in the latest published version, three weeks after it landed.) |
Re the last part, for any GitHub repo, docs on the default branch often contain unpublished changes - you need to check under the tag. |
I encourage maintainers to circle back to issues and PRs with a comment mentioning the version that includes a fix or merge. Since a lot of users will find issue pages while trying to self serve, the additional information helps reduce confusion and create awareness without too much extra work. |
That’s unsustainable to do manually, and my experience with bots that auto comment on release is that they’re excessively noisy. Unfortunately the best outcome would come with user education about how to understand when a closed issue/PR is, or isn’t, released. |
In practice, it's not bad. I also release when there are changes that fix issues. I find that proactive communication cuts down on the volume of pings, asks, and follow-up issues. A little extra work to solve a lot of extra work makes sense to me, but obviously you are welcome to do things however works best for you, I'm just sharing what I've learned. |
Adds an optional
allowedInvalidRoles: string[]
option for an allowlist of roles to no longer consider invalid.Fixes #574.