Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: align usage of jest expect across tests #827

Merged
merged 1 commit into from Feb 7, 2022

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 27, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 27, 2021

Codecov Report

Merging #827 (86830cc) into main (c460a8b) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 86830cc differs from pull request most recent head 685426d. Consider uploading reports for the commit 685426d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   99.22%   99.22%   -0.01%     
==========================================
  Files          98       98              
  Lines        1419     1417       -2     
  Branches      479      477       -2     
==========================================
- Hits         1408     1406       -2     
  Misses         11       11              
Impacted Files Coverage Δ
src/rules/aria-role.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c460a8b...685426d. Read the comment docs.

.gitignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
__tests__/src/util/isNonInteractiveRole-test.js Outdated Show resolved Hide resolved
@jessebeach
Copy link
Collaborator

@ljharb looks like your requested changes were made. Shall we get this landed?

@jessebeach jessebeach self-requested a review February 6, 2022 23:56
Copy link
Collaborator

@jessebeach jessebeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @armano2 !!

@ljharb ljharb merged commit 685426d into jsx-eslint:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants