Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better context for errors #86

Closed
ravi opened this issue Feb 9, 2015 · 3 comments
Closed

Better context for errors #86

ravi opened this issue Feb 9, 2015 · 3 comments
Assignees
@jordanbtucker
Labels
enhancement 👍 pull-request-welcome :octocat:

Comments

@ravi
Copy link

ravi commented Feb 9, 2015

It would help greatly if the command line json5 invocation provides more context for errors. For instance the following error message does not help find and fix an error in a ~ 600 line config file:

/tmp/node_modules/json5/lib/json5.js:54
            throw error;
                  ^
SyntaxError: Expected ']' instead of '{'
@ravi ravi mentioned this issue Feb 9, 2015
Closed
@jordanbtucker jordanbtucker self-assigned this Oct 9, 2015
amb26 added a commit to amb26/json5 that referenced this issue Dec 9, 2015
@amb26
Add support for line and column number context for errors: json5#86
e4ba49e
@amb26 amb26 mentioned this issue Dec 9, 2015
Merged
jordanbtucker added a commit that referenced this issue Mar 11, 2016
@jordanbtucker
Merge pull request #101 from amb26/issue-86
b45f2c0 
Add support for line and column number context for errors: #86
@jordanbtucker
Copy link
Member

Fixed by #101

@jasonswearingen
Copy link

could you also please update the npm version to include this?

@jordanbtucker
Copy link
Member

@jasonswearingen, yes. Please join in on the discussion in #113. I'll see about bumping the number ASAP. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanbtucker jordanbtucker

Labels
enhancement 👍 pull-request-welcome :octocat:
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ravi @jordanbtucker @aseemk @jasonswearingen