Fix: Eval as boolean

[XVincentX]

The current code will fail and fallback to default options values in case the minItems or maxItems is 0, which is not what we want. (0 evaluates as false)

I have tried to write a test for it but apparently the helpers I found are not good enough. I do not know how to assert that the length of a schema-generated array is not empty, nor a way to say "it has at least X elements"

[XVincentX]

@peterwald

[pateketrueke]

I have tried to write a test for it but apparently the helpers I found are not good enough. I do not know how to assert that the length of a schema-generated array is not empty, nor a way to say "it has at least X elements"

Yeah, I think we could add a minLength around: https://github.com/json-schema-faker/json-schema-faker/blob/master/tests/schema/helpers.js#L94

[XVincentX]

@pateketrueke

Tests added! If this is ready and could be releases, it'd be great 🙏

[codecov-io]

Codecov Report

Merging #619 (0cc08a1) into master (2e5c9f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   55.35%   55.35%           
=======================================
  Files          27       27           
  Lines         775      775           
=======================================
  Hits          429      429           
  Misses        346      346           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5c9f3...0cc08a1. Read the comment docs.

[XVincentX]

@pateketrueke Is this going to be merged/released automatically? What's the procedure?

[pateketrueke]

I was waiting for TravisCI to complete, thank you!

[XVincentX]

Ay perfecto!