jsoniter: Fix errors during reading integers from chunked io.Reader #477
Conversation
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 41 41
Lines 5115 5115
=======================================
Hits 4414 4414
Misses 560 560
Partials 141 141
Continue to review full report at Codecov.
|
|
Thanks for the bug report and the pr. I will check it in the next few days. |
|
@AllenX2018 any updates plz 🙏 ? We already using our fork with the current PR branch for a couple of weeks in production and we haven't noticed any issues. |
|
Hi! Sorry for the late reply. I leave a review comment and please check it. |
iter_int_test.go
Outdated
| @@ -0,0 +1,101 @@ | |||
| package jsoniter_test | |||
There was a problem hiding this comment.
Could you move this test case to the jsoniter_int_test.go under misc_tests directory?
There was a problem hiding this comment.
Done. Wasn't sure originally where to place this test 🤷
This commit fixes bug in Iterator.assertInteger method if the next conditions are met: - Iterator reads data from `io.Reader`, - expected value is `0` (zero) - `Iterator.tail == Iterator.head + 1` - `Iterator.tail < len(Iterator.buf)` - value in the buffer after `Iterator.tail` is presented from the previous read and has '.' character. Typical error which user cal see is: - assertInteger: can not decode float as int, error found in #X byte of ... Regression test added for checking the correct behaviour. Fixes json-iterator#476
mrVanboy
force-pushed
the
ib/476-fix-assertInteger-bug
branch
from
ae689be
to
cd30fdf
Compare
|
Merged. Thanks! |
…son-iterator#477) This commit fixes bug in Iterator.assertInteger method if the next conditions are met: - Iterator reads data from `io.Reader`, - expected value is `0` (zero) - `Iterator.tail == Iterator.head + 1` - `Iterator.tail < len(Iterator.buf)` - value in the buffer after `Iterator.tail` is presented from the previous read and has '.' character. Typical error which user cal see is: - assertInteger: can not decode float as int, error found in #X byte of ... Regression test added for checking the correct behaviour. Fixes json-iterator#476
This commit fixes bug in Iterator.assertInteger method if the next
conditions are met:
io.Reader,0(zero)Iterator.tail == Iterator.head + 1Iterator.tail < len(Iterator.buf)Iterator.tailis presented from the previous read and has '.' character.Typical error which user cal see is:
Regression test added for checking the correct behaviour.
Fixes #476