Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use $GITHUB_OUTPUT instead set-output(deprecated) #37

Merged
merged 2 commits into from Nov 30, 2022
Merged

fix: use $GITHUB_OUTPUT instead set-output(deprecated) #37

merged 2 commits into from Nov 30, 2022

Conversation

1wilber
Copy link
Contributor

@1wilber 1wilber commented Nov 24, 2022

In the deployments I noticed that some warnings were appearing due to the set-output being deprecated, I made the necessary changes to eliminate the warning!

I hope this is helpful, best regards

warning image:
image

links:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings

Copy link
Owner

@jsmrcaga jsmrcaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @h4k1 ! Thanks a lot for the Pull request, I'm guessing losing the warnings will make may devs happy ^^
I believe we could use the simpler name=value syntax though, what do you think?

entrypoint.sh Outdated
Comment on lines 77 to 91
echo "NETLIFY_OUTPUT<<EOF" >> $GITHUB_OUTPUT
echo "$NETLIFY_OUTPUT" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT

echo "NETLIFY_PREVIEW_URL<<EOF" >> $GITHUB_OUTPUT
echo "$NETLIFY_PREVIEW_URL" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT

echo "NETLIFY_LOGS_URL<<EOF" >> $GITHUB_OUTPUT
echo "$NETLIFY_LOGS_URL" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT

echo "NETLIFY_LIVE_URL<<EOF" >> $GITHUB_OUTPUT
echo "$NETLIFY_LIVE_URL" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are single line outputs I believe we could use the simpler one-line syntax
ex:

echo "action_state=yellow" >> $GITHUB_ENV

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @jsmrcaga, thank you for the review!
you can check again

@jsmrcaga
Copy link
Owner

LGTM!
Thanks again @h4k1, I'll be releasing a new version as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants