Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install node using nvm #23

Merged
merged 4 commits into from Nov 10, 2021
Merged

Install node using nvm #23

merged 4 commits into from Nov 10, 2021

Conversation

tpluscode
Copy link
Collaborator

Node 17 broke my webpack build because of changes in OpenSSL

In this PR I added support for .nvmrc file so that the right node version will be installed if overridden in the repo.

@@ -1,4 +1,4 @@
FROM node:current-stretch-slim
FROM node:current-stretch
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less slim image which comes with curl

entrypoint.sh Outdated
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.2/install.sh | bash
[ -s "$HOME/.nvm/nvm.sh" ] && \. "$HOME/.nvm/nvm.sh"

nvm install
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I install netlify-cli first, because once nvm installs into $HOME it is no longer possible to install globally.

Better ideas welcome

README.md Outdated Show resolved Hide resolved
@jsmrcaga
Copy link
Owner

jsmrcaga commented Nov 7, 2021

Also, add yourself in a Contributors section on the README! I completely forgot to ;)

@jsmrcaga jsmrcaga merged commit 20cf18b into jsmrcaga:master Nov 10, 2021
@jsmrcaga
Copy link
Owner

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants