Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip nvm #31

Closed
penx opened this issue May 30, 2022 · 4 comments
Closed

Option to skip nvm #31

penx opened this issue May 30, 2022 · 4 comments

Comments

@penx
Copy link

penx commented May 30, 2022

Thanks for building this action!

At the point I run action-netlify-deploy, my application has already been installed and built, and I have the version of node that I need.

I do have an .nvmrc file though, so this step I think will still install nvm, even though I don't need it.

fb6a5f9

Would it be possible to have an option to skip nvm rather than detecting it? 🙏

@jsmrcaga
Copy link
Owner

jsmrcaga commented Jun 2, 2022

Hi there @penx !

I had some time this evening and opened a simple pull request here
#33
if it's okay with you, can I let you review/approve. I'll then release a new version and hopefully you'll be good!

@penx
Copy link
Author

penx commented Jun 2, 2022

Looks great, thanks!

@jsmrcaga
Copy link
Owner

jsmrcaga commented Jun 2, 2022

@penx I've released version 1.8.0, if it works for you (using use_nvm: false) I'll let you close this issue! Thanks!

@penx
Copy link
Author

penx commented Jun 9, 2022

great, thanks, may not get a chance to test this until September but I've looked at the code and pretty certain it will work, thanks!

@penx penx closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants