Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails because of nvm while it's optional #27

Closed
ajbura opened this issue Nov 18, 2021 · 4 comments · Fixed by #28
Closed

Build fails because of nvm while it's optional #27

ajbura opened this issue Nov 18, 2021 · 4 comments · Fixed by #28

Comments

@ajbura
Copy link

ajbura commented Nov 18, 2021

https://github.com/ajbura/cinny/runs/4248572369?check_suite_focus=true

Since latest commit in your branch my builds are failing because I do not use .nvm.
@jsmrcaga
Copy link
Owner

Hey @ajbura , while we fix this I would advice you to add a sha or specific version on your workflow.
Thanks for the issue we will take a look at this asap!

@codler
Copy link

codler commented Nov 29, 2021

Can you update the readme?

@lucianojung
Copy link

Hi I have the same problem using master and v.1.7.1. Which version is working?

@jsmrcaga jsmrcaga mentioned this issue Dec 27, 2021
Merged
@jsmrcaga jsmrcaga linked a pull request Dec 27, 2021 that will close this issue
Inputs: do not run nvm if not needed #28
Merged
@jsmrcaga
Copy link
Owner

@codler @lucianojung @ajbura
Sorry this took so long.

I've openend a Pull request (linked to this issue). You can review it if you have the time to check if it matches your use cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inputs: do not run nvm if not needed jsmrcaga/action-netlify-deploy
4 participants
@codler @jsmrcaga @ajbura @lucianojung